Repository navigation
fix(release): give Windows smoke profiles a private ACL - #458
Merged
Merged
Conversation
The v1.94.0 Windows release smoke failed: the installed daemon refused to open its session history because the test profile sat under RUNNER_TEMP, which inherits the drive root's "Users may create folders" entry. Private storage refuses a directory another account can write to, so the daemon exited before it served /status. A real profile folder (%APPDATA%) grants only the user, SYSTEM and Administrators. Give the installed and normal smoke roots that same protected ACL. port-release-regression.ps1 already uses the private %TEMP%. Run 40172436472 passed every Windows step against the v1.94.0 draft assets with this change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v1.94.0 Windows release smoke (run 40172006465) failed at Install Setup.exe and run the installed application: the installed daemon exited with
The smoke roots live under
RUNNER_TEMP(D:\a\_temp), which inherits the drive root's "Users may create folders" entry. The new private storage (#454) refuses a directory another account can write to. A real profile folder (%APPDATA%) grants only the user, SYSTEM and Administrators, so this change gives the installed and normal smoke roots that same protected ACL.port-release-regression.ps1already uses the private%TEMP%and is unchanged.Evidence. The same tree on a diagnostic branch passed every Windows step against the unchanged v1.94.0 draft assets: run 40172436472 (installed app, packaged CLI, daemon and desktop, and the port-release check).
Not changed here. On Windows,
owner_private::protectvalidates a directory's own inherited ACL before restricting it, so storage relocated withBIOROUTER_PATH_ROOTunder a shared-writable parent (for example a folder at the root ofD:\) is refused even when Biorouter has just created it. macOS and Linux set 0700 and continue. That is security logic and is left for a separate, reviewed change.The v1.94.0 artifacts will be rebuilt from this commit so the release gate passes at the release's own source commit.
🤖 Generated with Claude Code