fix: use continuation-token pagination and full version responses - #9701
Open
farhann1 wants to merge 2 commits into
Open
fix: use continuation-token pagination and full version responses#9701farhann1 wants to merge 2 commits into
farhann1 wants to merge 2 commits into
Conversation
|
Azure Pipelines: Successfully started running 1 pipeline(s). 20 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates RLE environment APIs to use continuation-token pagination and consume complete version resources directly.
Changes:
- Replaces legacy cursor fields with
nextContinuationToken. - Eliminates per-version detail requests.
- Updates pagination and history tests.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
client.go |
Adds shared paginated response handling. |
list.go |
Uses continuation-token pagination. |
show.go |
Consumes full version responses. |
client_test.go |
Updates query-preservation coverage. |
list_test.go |
Updates pagination and version-history tests. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
📋 Prioritization NoteThanks for the contribution! The linked issue isn't in the current milestone yet. |
Comment on lines
+193
to
195
| if version.Id == current.Id && version.Version == current.Version { | ||
| version = *current | ||
| } else { | ||
| resolved, err := client.getEnvironmentVersion(ctx, current.Name, summary.Version) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
| version = *resolved | ||
| } |
Contributor
azure.ai.rle PR buildNote This is an unsigned development build. Install it only if you trust this PR. Install the extension: azd ext install "https://azuresdkartifacts.z5.web.core.windows.net/azd/extensions/pr/9701/azure-ai-rle.zip"
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9702