Repository navigation
feat: "Looking for Feedback" on tracks (flag track_feedback_requests) - #14750
Open
dylanjeffers wants to merge 1 commit into
Open
dylanjeffers wants to merge 1 commit into
dylanjeffers wants to merge 1 commit into
Conversation
Artists can turn on "Looking for Feedback" in a track's advanced settings (web and mobile). Flagged tracks get a Feedback Wanted tag on tiles and the track page, and Explore gets a Looking for Feedback section, newest request first. Feedback comes in as regular timestamped comments, so the toggle is hidden and cleared when comments are disabled. SDK: feedbackRequested on track models and update metadata, and tracks.getFeedbackTracks. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: e08c688 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Artists can ask for feedback on a track. Listeners leave it as ordinary timestamped comments, which pairs with the feed waveform comment box in #14736. Behind
track_feedback_requests(on in dev, off in prod).Backend: AudiusProject/api#1068 (field +
GET /v1/tracks/feedback) and OpenAudio/go-openaudio#625 (indexer).feedbackRequestedonTrackand the create/update bodies,feedbackRequestedin the upload/update metadata schema, andtracks.getFeedbackTracks. Generated files were hand-trimmed to just these changes. A full regen against the current spec also pulls in unrelated drift (waveform, notification models).feedback_requestedwhen it's set, so other edit flows never clear it by accident.Test plan
tsc --noEmitfor sdk, common and web (only errors are existing SolanaClaimableTokensProgramones from the local spl build); mobile tsc has no errors in changed files/v1/tracks/feedbackstubbed in the page (the endpoint isn't live yet): the Explore carousel loads from the new endpoint, tiles show Feedback Wanted, and the track page header shows it next to TRACKBefore turning the flag on in prod: api#1068 deployed, and the api bumped to a go-openaudio that includes #625.
🤖 Generated with Claude Code