Repository navigation
fix: match untagged Ollama model names against ':latest' - #611
Open
ieCecchetti wants to merge 1 commit into
Open
ieCecchetti wants to merge 1 commit into
ieCecchetti wants to merge 1 commit into
Conversation
check_ollama_model_exists compares the configured name with ollama.list() exactly (since AsyncFuncAI#549), but Ollama lists untagged pulls as '<name>:latest'. The default embedder config uses 'nomic-embed-text', so the check fails with "Ollama model 'nomic-embed-text' not found" even when it is installed. Treat an untagged name as ':latest' on both sides. Fixes AsyncFuncAI#579.
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
check_ollama_model_existsnow treats an untagged model name as<name>:latest, on both the configured name and the names returned byollama.list().Why
Since #549 the check compares names exactly, but Ollama lists untagged pulls as
<name>:latest. The shippedembedder.ollama.json.bakusesnomic-embed-text, so following the Ollama setup fails withOllama model 'nomic-embed-text' not foundeven though the model is installed. Fixes #579.Tests
tests/unit/test_ollama_model_check.pymocksollama.Client.listand covers untagged vs:latest, explicit tags, mismatched tags and registry hosts with ports.