Repository navigation
fix(i18n): drop the duplicate ZH_CN "Idle" key - #729
Merged
Merged
Conversation
The Approvals Inbox strings added a second `Idle: '空闲'` to the ZH_CN table, beside the original in the status words. Same value, so nothing changed on screen, but every build warned: [WARNING] Duplicate key "Idle" in object literal [duplicate-object-key]
Owner
|
Thanks @timkjr, and welcome! This removes the second I checked that the translation table is identical afterwards (same keys, same order, same values), and typecheck, lint, the frontend syntax and format checks and the i18n tests all pass. Nothing to change here; this is good to merge once CI finishes. |
Owner
|
Merged in 1.47.0 (https://github.com/Ark0N/Codeman/releases/tag/codeman%401.47.0). Thank you, the build is quiet again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Approvals Inbox strings added a second
Idle: '空闲'to the ZH_CN table insrc/web/public/i18n.js, next to the original among the status words. Both entries have the same value, so nothing changes on screen, but every build warns:This removes the later copy. After the change,
npm run buildhas no warnings, and the i18n tests andformat:checkpass.🤖 Generated with Claude Code