Run control-operator tests in CI - #824
Merged
Merged
Conversation
justonedev1
previously approved these changes
Jul 3, 2026
justonedev1
self-requested a review
July 3, 2026 13:21
justonedev1
reviewed
Jul 3, 2026
| - run: (make vendor) | ||
| - run: (make) | ||
| - run: (make test) | ||
| - run: (cd control-operator && make test) |
Collaborator
There was a problem hiding this comment.
maybe add just as well simple make as well to check if we can build everything?
Collaborator
Author
There was a problem hiding this comment.
let's try. now it can't find protoc anyway.
justonedev1
force-pushed
the
knopers8-patch-2
branch
from
July 27, 2026 15:17
8783b78 to
3df6c6a
Compare
Collaborator
|
I split github workflows for control and control-operator as those should be thought about as independent binaries (except that core depends on the package from control-operator). However I think that there should some common setups, like the same golang version in all workflows etc... but this demonstrates working workflow for control-operator |
Collaborator
Author
|
thanks, let's start with that. indeed we should merge the two builds though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just checking if it works.