Skip to content

Potential fix for code scanning alert no. 1: Incomplete URL substring sanitization #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cyyeh merged 2 commits into from
Oct 30, 2026
Merged

Potential fix for code scanning alert no. 1: Incomplete URL substring sanitization #11

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0e815d6
Potential fix for code scanning alert no. 1: Incomplete URL substring…
cyyeh Oct 30, 2026
f48d949
Fix GitHub invitation lookup in the page tests
cyyeh Oct 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion tests/test_app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -531,7 +531,14 @@ def test_a_model_the_page_does_not_support_says_why_and_offers_a_github_issue_fi
assert query["title"] == [title] and asks in body
assert "`meta-llama/Llama-3.2-1B-Instruct`" in body and "https://huggingface.co/meta-llama/Llama-3.2-1B-Instruct" in body and "`llama`" in body
assert "localhost" not in button.proto.url # never the server's address, which may be a private one
[invite] = [m.value for m in at.markdown if "github.com" in m.value]
[invite] = [
m.value
for m in at.markdown
if any(
(host := urlsplit(link).hostname or "") == "github.com" or host.endswith(".github.com")
for link in re.findall(r"\[[^\]]*\]\(([^)]+)\)", m.value)
)
]
assert f"{page.ISSUES_URL}?q=is%3Aissue%20llama" in invite # a search for one someone opened already
if locale == "en-US":
assert not CJK.search(button.label + title + body + invite)
Expand Down
Loading