Expose EditableText.SetTextContents on Unix - #762
Open
mirsella wants to merge 6 commits into
Open
Conversation
DataTriny
requested changes
Aug 16, 2026
The removed explanation described restrictions that do not match how other adapters determine EditableText support.
Expose EditableText for text inputs with text ranges, consistent with the other platform adapters. Read-only state and action advertisement do not determine interface availability.
Remove the generic dispatch helpers introduced for EditableText and route actions through the established do_action_internal helper again. SetTextContents now handles read-only nodes locally while D-Bus interface registration remains the source of capability validation.
Use the interface-local map_error pattern shared by the other AT-SPI interfaces so node errors are translated consistently.
Keep EditableText behavior tests beside PlatformNode and restore the adapter cache tests to their focused fixtures. The relocated test covers writable dispatch, read-only rejection, and text-range-based interface support.
Author
|
hello ! thanks for the review :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #761.
This exposes AT-SPI
EditableTextfor writable text inputs that handle stringSetValuerequests.SetTextContentsforwards the new contents asAction::SetValuewithActionData::Value.Numeric controls continue to use AT-SPI
Value. The remainingEditableTextmethods returnNotSupportedbecause AccessKit does not have matching clipboard or range-editing actions.