Adapt to rocq-prover/rocq#22271 - #589
Merged
Merged
Conversation
5 tasks
Contributor
|
Should be ready to merge |
Contributor
|
Thanks for the early notice. One more warning to silence in the Makefile... Merging after CI completes. |
SkySkimmer
reviewed
Aug 10, 2026
| # deprecated-from-Coq: | ||
| # see above | ||
| # unknown-option: | ||
| # the "Set Extraction Prefix" command was introduced in 9.4 |
Contributor
There was a problem hiding this comment.
wouldn't it make more sense to silence the warning locally?
Contributor
There was a problem hiding this comment.
Well, this applies only to the extraction/extraction.v file, not the other Rocq source files, so it's rather local already. Plus, I like to put all the warning management in a single file (the Makefile), in the hope that it makes it easier to remove warnings when we drop support for old versions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adapt to rocq-prover/rocq#22271