Repository navigation
Conversation
Gate (tools/ci/check_site_paths.py): scan experiments/, scaling-study/, requirements/, .github/ and root-level files; match grand/gpfs/lustre roots; count internal identities (usernames, old repo name) on the same ratchet. Scrub: bioreason/GRPO scripts, DAOS/interactive launch scripts, universal_evaluator, convert_parquet_to_webdataset, prism_designs.yaml, KEGG docs, the multi-agent skill and the _repo_paths clone hint now use PRISM_* variables or placeholders. Remove three study-record experiment files; mark the rest with TODO(release). Document PRISM_CONDA_ENV / PRISM_REPO_ROOT. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Sande33p
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refs #2 (open-source readiness). A review comment found
/lus/flare/projects/ModCon/<user>/BaseMM_PRISMindocs/skills/prism-multi-agent-workflow/SKILL.md. Earlier scrubs missed it because the hygiene gate could not see it, so this PR fixes the leak and widens the gate. It does not close #2 and leaves a baselined allowlist (below).Gate (
tools/ci/check_site_paths.py)experiments/,scaling-study/,requirements/,.github/and root-level tracked files. Previously these were outsideSCANNED_PREFIXES;experiments/alone held ~22 paths.grand,gpfsandlustreroots./soft/...is deliberately not matched (public system software).ngetty,abalaji,smadireddy,BaseMM_PRISMcount on the same ratchet (not double-counted inside a matched path). Exempt:CITATION.cff,pyproject.toml,.mailmap,SECURITY.md,CODE_OF_CONDUCT.md(deliberate author/contact emails), and the gate and its test.tests/test_site_path_gate.py.Scrubbed
prism-multi-agent-workflow/SKILL.md) and the staleBaseMM_PRISM.gitclone hint insrc/_repo_paths.py:40.smoke_test_grpo.sh,setup_daos_models.sh,run_agpt2b_interactive.sh,run_composite_interactive.sh,convert_parquet_to_webdataset.py,launch_polaris.pyhelp, KEGG docs,tests/test_isoflop_launcher_flag.py.experiments/prism_designs.yaml: removed the/raid/<user>resume path, the CALVINcalvin_rootand the pinned AuroraGPTbackbone_idoverrides.PRISM_CONDA_ENVandPRISM_REPO_ROOT(documented in.env.templateanddocs/platforms/site_paths.md; scripts fail withset <NAME>if unset).Removed
experiments/stage_a_round1_olmo3_1b.yaml,ablation_catalog.yaml,qwen3_siglip_smokes.yaml: internal study records with no code dependents.Behavior changes to review
global_step140300; it usesPRISM_AURORAGPT_2B_CHECKPOINT.tools/universal_evaluator.pySciTS validation raisesValueErrorif neitherPRISM_VAL_SHARDS_DIRnorPRISM_DATA_ROOTis set (was a personal path).scripts/setup_daos_models.shneedsMODEL_ROOTorPRISM_HF_HUB;MODEL_ROOT_ALTis an optional override.PRISM_REPO_ROOT; the AGPT2B one needsPRISM_AURORAGPT_2B_CHECKPOINT.State of the allowlist
tools/ci/site_path_allowlist.json: 68 files, 197 paths (main had 73 files / 236 paths; the wider scan and identity check add baselined entries, and the scrubs above remove more than they add, for a net drop). The ratchet only goes down.By area: docs 56, tools 52, applications 37, scripts 34, tests 15,
.github1, root 1, src 1. Largest:scripts/setup_daos_container.sh(26),applications/vision_language/hydrate_pixmo_pointing.py(10),docs/platforms/daos_setup.md(10).Deliberately still present:
NOTICEand.github/dependabot.ymlreference the internal repo as a tracking link; several docs linkgithub.com/AI-ModCon/BaseMM_PRISM/....src/data/kegg_curation/entrez_client.py:28sendsBaseMM_PRISM-kegg_curationas the NCBI tool name; renaming changes what NCBI sees, so left for a decision.stage_a_round1_batch.sh,hold_4node_debug_scaling.sh,build_stage_a_plan.py) and the kept study filesLLM_timeseries_scaling.yaml,qwen3_siglip_scaling.yaml,qwen3_siglip_2node_search.yamlcarryTODO(release): keep and scrub, or remove.Type of Change
Compatibility
PRISM_*env vars, see above)src.*paths are unchanged. Three experiment catalogs were removed; nothing in code or tests loads them.How Has This Been Tested?
python3.11 tools/ci/check_site_paths.py→OK: 68 allowlisted files, 197 hardcoded site paths, none newbash -non every edited shell script;py_compileon edited Python;yaml.safe_loadon everyexperiments/*.yaml.make test,tests/test_site_path_gate.py,test_docs_consistency.py,test_makefile_ci_parity.py) — no usable pytest on the HPC login node. Please rely on CI. Also not run: the edited scripts themselves, ormake docs.New Dependencies, Data, or Assets
None.
Checklist
AI/LLM Assistance
Drafted with Claude Code; the human reviewer and author checks above are left for the humans.
Additional Context
Remaining items on #2 are outside this PR: baselined allowlist entries above, and the Stage A / study-file keep-or-remove decision.