Repository navigation
Add n2-highmem and more n2-standard CPU device types - #1199
Merged
scaliby merged 1 commit intoNov 4, 2026
Merged
Conversation
mridul-sahu
requested review from
FIoannides,
SikaGrr,
jamOne-,
scaliby and
stony-tark
as code owners
November 4, 2026 06:59
There was a problem hiding this comment.
Code Review
This pull request expands the supported CPU machine types in XPK by adding several n2-highmem and n2-standard configurations. It introduces a helper function get_cpu_system_characteristics_map to dynamically generate CPU device types for various VM counts, updates the documentation and README to reflect these additions, and includes comprehensive unit tests to verify the new behavior. No review comments were provided, so I have no feedback to evaluate.
scaliby
approved these changes
Nov 4, 2026
Merged
via the queue into
AI-Hypercomputer:main
with commit Nov 4, 2026
ddd1b0b
29 of 30 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title: Add n2-highmem and more n2-standard CPU device types
Adds CPU device types for n2-highmem-{2,4,8,16,32,48,64,96} and n2-standard-{8,16,48,96}, following #1128 (n2-standard-4). Entries are generated by get_cpu_system_characteristics_map (like the TPU helper) for VM counts 1, 2, 4, 5, 8, 10, 16, 20, 32, 40, 64, 80, 128, 160, 256, 320, 512, 640: powers of two and 5 × powers of two, at most 1,000 (GKE's nodes per node pool and zone). Existing CPU entries are unchanged.
Motivation: running many simulated TPU hosts per VM needs high-memory or mid-size machines and non-power-of-two VM counts.
Testing: unit tests for the helper and catalog lookups; make run-unittests 513 passed; pyink/pylint/mypy clean. Used end to end (as a runtime catalog patch) for cluster create and workload create with n2-highmem-8-320 and n2-highmem-4-640 on GKE.