Repository navigation
Run the live 51Did redemption tests with the 51Did license key - #116
Merged
Merged
Conversation
Without a license key the browser creator context tests skip, so redeeming a sealed result was never exercised in CI.
Redemption only opens a sealed result for a license key of the account whose resource key sealed it, so the 51Did license key is run with the 51Did resource key rather than read alongside every key.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The live cloud 51Did workflow passed no license key, so the server-side half of the creator context check (redeeming a sealed result with a license key) never ran in CI. Both
BrowserCreatorContextLiveTeststests skipped on every run. They also skipped for a second reason: the service no longer creates a 51Did for a browser-shaped request until the page has also reported51D_ProfileIds,51D_IsVisibleand51D_HasWebDriver, and the skip message cut that reason off.What changed
.github/workflows/cloud-51did.yml: adds the_51DEGREES_RESOURCE_KEY_51DIDvariable and the_51DEGREES_LICENSE_KEY_51DIDsecret. Each iteration sets_51DEGREES_LICENSE_KEYfrom the license key with the same suffix as its resource key, because the service only opens a sealed result for a license key of the account whose resource key sealed it. Pytest runs with-rsso each skip says why, and the log names which license key (if any) each iteration used.fiftyone_pipeline_did/tests/test_did_client_live.py: the browser-shaped requests send the three snippet results the service now waits for, and a refused create reports the full probabilistic null reason.Testing
Dispatched on this branch: https://github.com/51Degrees/pipeline-python/actions/runs/39592610680. With
_51DEGREES_RESOURCE_KEY_51DIDand_51DEGREES_LICENSE_KEY_51DIDall 6 live tests pass, includingtest_a_page_creates_reads_back_verifies_and_redeems(verified) andtest_another_browser_redeems_as_a_mismatch_naming_every_factor(mismatch, all nine factors). BESPOKE, with no license key, redeems as unreadable and then skips, as before. BASIC is not entitled to marketing usages, so its browser tests still skip.