From 13e010d4d0170c0ce1d359078a94cc6d65020a4b Mon Sep 17 00:00:00 2001
From: ptweezy <ptweezy@cronstable.dev>
Date: Sat, 24 Oct 2026 12:30:59 -0400
Subject: [PATCH 1/2] Remove the temporary files that the tests leave behind

test_threaded_write and test_threaded_write_oversized_block_no_error
never removed their NamedTemporaryFile(delete=False) files. BaseTest in
test_gzip_compliance.py created a file in __init__(), but pytest
creates TestCase instances while it collects tests, and only the
instances that ran a test removed their file. test_repr and test_seek
removed their files only when they passed. Use tmp_path, and create the
file name in setUp().
---
 tests/test_gzip_compliance.py |  9 +++------
 tests/test_igzip.py           | 12 ++++--------
 tests/test_igzip_threaded.py  |  8 ++++----
 3 files changed, 11 insertions(+), 18 deletions(-)

diff --git a/tests/test_gzip_compliance.py b/tests/test_gzip_compliance.py
index 5d71577c..bca9fd40 100644
--- a/tests/test_gzip_compliance.py
+++ b/tests/test_gzip_compliance.py
@@ -65,14 +65,11 @@ def seek(self, *args):
 
 class BaseTest(unittest.TestCase):
 
-    def __init__(self, methodName):
+    def setUp(self):
+        # Make a unique file name. The tests create the file themselves.
         fileno, self.filename = tempfile.mkstemp()
         os.close(fileno)
-        super().__init__(methodName)
-
-    def setUp(self):
-        if os.path.exists(self.filename):
-            os.unlink(self.filename)
+        os.unlink(self.filename)
 
     def tearDown(self):
         if os.path.exists(self.filename):
diff --git a/tests/test_igzip.py b/tests/test_igzip.py
index 4f0e44f3..f185ac80 100644
--- a/tests/test_igzip.py
+++ b/tests/test_igzip.py
@@ -14,7 +14,6 @@
 import itertools
 import os
 import re
-import shutil
 import struct
 import subprocess
 import sys
@@ -39,11 +38,9 @@ def test_wrong_compresslevel_igzipfile():
     error.match("Compression level should be between 0 and 3")
 
 
-def test_repr():
-    tempdir = tempfile.mkdtemp()
-    with igzip.IGzipFile(os.path.join(tempdir, "test.gz"), "wb") as test:
+def test_repr(tmp_path):
+    with igzip.IGzipFile(str(tmp_path / "test.gz"), "wb") as test:
         assert "<igzip _io.BufferedWriter name='" in repr(test)
-    shutil.rmtree(tempdir)
 
 
 def test_write_readonly_file():
@@ -602,9 +599,9 @@ def test_concatenated_gzip():
     assert data == result
 
 
-def test_seek():
+def test_seek(tmp_path):
     from io import SEEK_CUR, SEEK_END, SEEK_SET
-    with tempfile.NamedTemporaryFile("wb", delete=False) as tmpfile:
+    with open(tmp_path / "test.gz", "wb") as tmpfile:
         tmpfile.write(gzip.compress(b"X" * 500 + b"A" + b"X" * 499))
         tmpfile.write(gzip.compress(b"X" * 500 + b"B" + b"X" * 499))
         tmpfile.write(gzip.compress(b"X" * 500 + b"C" + b"X" * 499))
@@ -637,7 +634,6 @@ def test_seek():
         assert gzip_file.read(1) == b""
         gzip_file.seek(-1500, SEEK_END)
         assert gzip_file.read(1) == b"C"
-    os.remove(tmpfile.name)
 
 
 def test_bgzip():
diff --git a/tests/test_igzip_threaded.py b/tests/test_igzip_threaded.py
index 572ece53..21dd366e 100644
--- a/tests/test_igzip_threaded.py
+++ b/tests/test_igzip_threaded.py
@@ -37,8 +37,8 @@ def test_threaded_read():
 
 @pytest.mark.parametrize(["mode", "threads"],
                          itertools.product(["wb", "wt"], [1, 3, -1]))
-def test_threaded_write(mode, threads):
-    with tempfile.NamedTemporaryFile("wb", delete=False) as tmp:
+def test_threaded_write(tmp_path, mode, threads):
+    with open(tmp_path / "output.gz", "wb") as tmp:
         # Use a small block size to simulate many writes.
         with igzip_threaded.open(tmp, mode, threads=threads,
                                  block_size=8*1024) as out_file:
@@ -87,12 +87,12 @@ def test_threaded_read_error():
 
 @pytest.mark.timeout(5)
 @pytest.mark.parametrize("threads", [1, 3])
-def test_threaded_write_oversized_block_no_error(threads):
+def test_threaded_write_oversized_block_no_error(tmp_path, threads):
     # Random bytes are incompressible, and therefore are guaranteed to
     # trigger a buffer overflow when larger than block size unless handled
     # correctly.
     data = os.urandom(1024 * 63)  # not a multiple of block_size
-    with tempfile.NamedTemporaryFile(mode="wb", delete=False) as tmp:
+    with open(tmp_path / "output.gz", "wb") as tmp:
         with igzip_threaded.open(
                 tmp, "wb", compresslevel=3, threads=threads,
                 block_size=8 * 1024

From 0874f9e8efda4dd846957f67cd1e9d625c74ef5a Mon Sep 17 00:00:00 2001
From: ptweezy <ptweezy@cronstable.dev>
Date: Sat, 24 Oct 2026 16:47:49 -0400
Subject: [PATCH 2/2] Pass a list instead of an iterator to parametrize in
 test_threaded_write

pytest 10 turns the PytestRemovedIn10Warning for iterators into an
error. #297 changes the other calls, but this decorator is next to the
line that the previous commit changes.
---
 tests/test_igzip_threaded.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/test_igzip_threaded.py b/tests/test_igzip_threaded.py
index 21dd366e..51581c75 100644
--- a/tests/test_igzip_threaded.py
+++ b/tests/test_igzip_threaded.py
@@ -36,7 +36,7 @@ def test_threaded_read():
 
 
 @pytest.mark.parametrize(["mode", "threads"],
-                         itertools.product(["wb", "wt"], [1, 3, -1]))
+                         list(itertools.product(["wb", "wt"], [1, 3, -1])))
 def test_threaded_write(tmp_path, mode, threads):
     with open(tmp_path / "output.gz", "wb") as tmp:
         # Use a small block size to simulate many writes.