Skip to content

profiler.id is always attached, even if ProfilingManager is rate-limiting #5906

Description

@markushi

This has been observed for Perfetto Profiling in our demo app, where a trace had a profiler.id set, but the actual profile was missing.

When linking traces and profiles, we link them unconditionally, e.g. here:

private @NotNull SentryId getProfilerId() {

This stems from ProfilingManager, where requests can be rate-limited, and rejections are only reported via async profiling result. Or in other words PerfettoProfiler.start() will always return true, and only processResult at a later point will be able to detect rate limiting.

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions