From 5d8a3170c44d321dfc2d6abf42563e9d9ac9f0b1 Mon Sep 17 00:00:00 2001 From: jialecl Date: Thu, 20 Aug 2026 11:29:11 +0200 Subject: [PATCH 1/3] Improved accessibility issues in Popover --- packages/lib/src/popover/Popover.tsx | 54 ++++++++++++++-------------- 1 file changed, 28 insertions(+), 26 deletions(-) diff --git a/packages/lib/src/popover/Popover.tsx b/packages/lib/src/popover/Popover.tsx index cc4760664..541e19c67 100644 --- a/packages/lib/src/popover/Popover.tsx +++ b/packages/lib/src/popover/Popover.tsx @@ -57,32 +57,34 @@ const DxcPopover = ({ return ( <> - - {asChild ? ( - children - ) : ( - handleTrigger(isControlled.current, setOpened, true, onOpen) - : undefined - } - onMouseEnter={ - actionToOpen === "hover" - ? () => handleTrigger(isControlled.current, setOpened, true, onOpen) - : undefined - } - onMouseLeave={ - actionToOpen === "hover" - ? () => handleTrigger(isControlled.current, setOpened, false, onClose) - : undefined - } - > - {children} - - )} - + {asChild ? ( + + {children} + + ) : ( + handleTrigger(isControlled.current, setOpened, true, onOpen) : undefined + } + onMouseEnter={ + actionToOpen === "hover" ? () => handleTrigger(isControlled.current, setOpened, true, onOpen) : undefined + } + onMouseLeave={ + actionToOpen === "hover" + ? () => handleTrigger(isControlled.current, setOpened, false, onClose) + : undefined + } + > + {children} + + )} {portalContainer && ( Date: Thu, 20 Aug 2026 11:53:13 +0200 Subject: [PATCH 2/3] removed asChild from trigger --- packages/lib/src/popover/Popover.tsx | 1 - 1 file changed, 1 deletion(-) diff --git a/packages/lib/src/popover/Popover.tsx b/packages/lib/src/popover/Popover.tsx index 541e19c67..4415648e3 100644 --- a/packages/lib/src/popover/Popover.tsx +++ b/packages/lib/src/popover/Popover.tsx @@ -69,7 +69,6 @@ const DxcPopover = ({ ) : ( handleTrigger(isControlled.current, setOpened, true, onOpen) : undefined } From affdd8d318cae8c327e85d0d633a8310984cc30c Mon Sep 17 00:00:00 2001 From: jialecl Date: Thu, 20 Aug 2026 12:12:02 +0200 Subject: [PATCH 3/3] remove button default styling --- packages/lib/src/popover/Popover.tsx | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/packages/lib/src/popover/Popover.tsx b/packages/lib/src/popover/Popover.tsx index 4415648e3..c4314b43b 100644 --- a/packages/lib/src/popover/Popover.tsx +++ b/packages/lib/src/popover/Popover.tsx @@ -69,6 +69,16 @@ const DxcPopover = ({ ) : ( handleTrigger(isControlled.current, setOpened, true, onOpen) : undefined } @@ -81,7 +91,9 @@ const DxcPopover = ({ : undefined } > - {children} + + {children} + )} {portalContainer && (