From 8ecd6a5a1b565e431edaf06d2b8a3015f8893f87 Mon Sep 17 00:00:00 2001 From: Claude Date: Wed, 12 Aug 2026 13:18:29 +0000 Subject: [PATCH] fix(host): make vendor-hermes --silent actually silent MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The spinners were passed `isEnabled: !silent`. A disabled ora spinner still writes `- ` on start and the success/fail symbol on completion (to stderr) — it only skips the animation. `isSilent` is the option that suppresses output entirely. Callers capture stdout only (`$(... --silent)` in CI and the Gradle error message, backticks in patch-hermes.rb), so the stray output was noise rather than a broken path, but `--silent` now does what it says. Co-Authored-By: Claude Opus 5 Claude-Session: https://claude.ai/code/session_01HX4imsygeawVtsmoP1sj3F --- .changeset/silent-vendor-hermes.md | 9 +++++++++ packages/host/src/node/cli/hermes.ts | 4 ++-- 2 files changed, 11 insertions(+), 2 deletions(-) create mode 100644 .changeset/silent-vendor-hermes.md diff --git a/.changeset/silent-vendor-hermes.md b/.changeset/silent-vendor-hermes.md new file mode 100644 index 00000000..272847f4 --- /dev/null +++ b/.changeset/silent-vendor-hermes.md @@ -0,0 +1,9 @@ +--- +"react-native-node-api": patch +--- + +Make `vendor-hermes --silent` actually silent. The spinners were passed +`isEnabled: false`, which stops the animation but still writes the spinner text +and its final symbol to stderr. They now use `isSilent`, which suppresses the +output entirely, leaving the vendored Hermes path on stdout as the command's +only output. diff --git a/packages/host/src/node/cli/hermes.ts b/packages/host/src/node/cli/hermes.ts index b1f74a3c..74f8680b 100644 --- a/packages/host/src/node/cli/hermes.ts +++ b/packages/host/src/node/cli/hermes.ts @@ -90,7 +90,7 @@ export const command = new Command("vendor-hermes") successText: "Removed existing Hermes clone", failText: (error) => `Failed to remove existing Hermes clone: ${error.message}`, - isEnabled: !silent, + isSilent: silent, }, ); } @@ -123,7 +123,7 @@ export const command = new Command("vendor-hermes") text: `Cloning Hermes into ${prettyPath(hermesPath)}`, successText: "Cloned Hermes", failText: (err) => `Failed to clone Hermes: ${err.message}`, - isEnabled: !silent, + isSilent: silent, }, ); } catch (error) {