Skip to content

Commit 465fb6f

Browse files
Philipp0205cursoragentKurrle, Philipp
authored
Publish the p2 update site on every merge to main (#55)
The site was never reachable: publishing only ran for v* tags and manual dispatches, so p2/ on main held nothing but a placeholder and Pages answered 404 for the documented install URL. Run the full test suite in the build job as well, now that the parser and test fixes make it pass. Co-authored-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: Kurrle, Philipp <philipp.kurrle+ADVNTST@advantest.com>
1 parent d4e27fc commit 465fb6f

2 files changed

Lines changed: 13 additions & 10 deletions

File tree

.github/workflows/p2-site.yml

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,8 @@ on:
44
push:
55
branches: [main, "cursor/**"]
66
tags: ["v*"]
7+
# The publish job commits back to p2/; do not rebuild for that commit.
8+
paths-ignore: ["p2/**"]
79
pull_request:
810
workflow_dispatch:
911

@@ -27,9 +29,7 @@ jobs:
2729
java-version: "21"
2830
cache: maven
2931
- name: Build and verify p2 repository
30-
# Existing unit tests fail independently of packaging; the site
31-
# must still be produced so it can be published.
32-
run: ./mvnw --batch-mode clean verify -DskipTests
32+
run: ./mvnw --batch-mode clean verify
3333
- name: Resolve feature installation
3434
run: >-
3535
./mvnw --batch-mode --non-recursive
@@ -48,7 +48,10 @@ jobs:
4848
# GitHub Pages serves this repository's default branch, so the published
4949
# update site is the committed p2/ directory rather than a Pages artifact.
5050
publish:
51-
if: startsWith(github.ref, 'refs/tags/v') || github.event_name == 'workflow_dispatch'
51+
if: >-
52+
github.ref == 'refs/heads/main'
53+
|| startsWith(github.ref, 'refs/tags/v')
54+
|| github.event_name == 'workflow_dispatch'
5255
needs: build
5356
runs-on: ubuntu-latest
5457
permissions:

README.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -139,13 +139,13 @@ resolved earlier. If Eclipse reports that it cannot download an older
139139
version, select the site under **Preferences → Install/Update →
140140
Available Software Sites** and click **Reload**.
141141

142-
Enable GitHub Pages for this repository (**Settings → Pages**, deploy
143-
from `main` at `/`) so the committed `p2/` directory is served.
142+
GitHub Pages serves this repository from `main` at `/`
143+
(**Settings → Pages**), which is what makes the committed `p2/`
144+
directory reachable.
144145

145-
Releases are published by pushing a `v*` tag or by running the
146-
**Build and publish p2 update site** workflow manually. Every push and
147-
pull request still builds the site and uploads it as the
148-
`p2-update-site` artifact.
146+
Every merge to `main` republishes the site, and a `v*` tag or a manual
147+
run of **Build and publish p2 update site** does the same. Pull requests
148+
only build the site and upload it as the `p2-update-site` artifact.
149149

150150
To test an unreleased change, download that artifact from the workflow
151151
run and add the extracted folder as a local repository.

0 commit comments

Comments
 (0)