From e12d578f4b2cd86d1f6e133663241e5a73c88fdb Mon Sep 17 00:00:00 2001 From: Fiaguhop137 Date: Sat, 31 Oct 2026 10:34:38 -0400 Subject: [PATCH 1/2] test --- .../java/dev/intensed/fallback/api/RandomDialogAPI.java | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/src/main/java/dev/intensed/fallback/api/RandomDialogAPI.java b/src/main/java/dev/intensed/fallback/api/RandomDialogAPI.java index 3796e59..fd2d44e 100644 --- a/src/main/java/dev/intensed/fallback/api/RandomDialogAPI.java +++ b/src/main/java/dev/intensed/fallback/api/RandomDialogAPI.java @@ -30,9 +30,14 @@ public static int execute(CommandSourceStack source, int from, int to, String pr objective = scoreboard.addObjective(OBJECTIVE_NAME, ObjectiveCriteria.DUMMY, Component.literal("Fallback Dialogs"), ObjectiveCriteria.RenderType.INTEGER, false, null); } ArrayList available = new ArrayList(); - for (int number = from; number <= to; ++number) { + for(int number=from;number<=to;++number){ int score; - if (blocked.contains(number) || (score = scoreboard.getOrCreatePlayerScore(ScoreHolder.forNameOnly((scoreName = RandomDialogAPI.getScoreName(prefix, number))), objective).get()) != 0) continue; + if(blocked.contains(number)){continue;} + scoreName=RandomDialogAPI.getScoreName(prefix,number); + if(scoreName==null){continue;} // you can put smth else here if you want to handle null differently; this exists cuz i noticed your code would just have a heart attack and explode if scoreName was null so i added this to prevent that ^w^ + ScoreHolder holder=ScoreHolder.forNameOnly(scoreName); //also i expanded your giant unreadable line into multiple lines for better readabilnessility + score=scoreboard.getOrCreatePlayerScore(holder,objective).get(); + if(score!=0){continue;} available.add(number); } if (available.isEmpty()) { From f644a1891cd0c53ce2bcee867b285d4249328891 Mon Sep 17 00:00:00 2001 From: Fiaguhop137 Date: Sat, 31 Oct 2026 11:36:17 -0400 Subject: [PATCH 2/2] 1f89a-2026.10.31-11.36.17-0400 --- src/main/java/dev/intensed/fallback/api/RandomDialogAPI.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/main/java/dev/intensed/fallback/api/RandomDialogAPI.java b/src/main/java/dev/intensed/fallback/api/RandomDialogAPI.java index fd2d44e..a76d2d5 100644 --- a/src/main/java/dev/intensed/fallback/api/RandomDialogAPI.java +++ b/src/main/java/dev/intensed/fallback/api/RandomDialogAPI.java @@ -32,12 +32,12 @@ public static int execute(CommandSourceStack source, int from, int to, String pr ArrayList available = new ArrayList(); for(int number=from;number<=to;++number){ int score; - if(blocked.contains(number)){continue;} + if(blocked.contains(number))continue; scoreName=RandomDialogAPI.getScoreName(prefix,number); if(scoreName==null){continue;} // you can put smth else here if you want to handle null differently; this exists cuz i noticed your code would just have a heart attack and explode if scoreName was null so i added this to prevent that ^w^ ScoreHolder holder=ScoreHolder.forNameOnly(scoreName); //also i expanded your giant unreadable line into multiple lines for better readabilnessility score=scoreboard.getOrCreatePlayerScore(holder,objective).get(); - if(score!=0){continue;} + if(score!=0)continue; available.add(number); } if (available.isEmpty()) {