From 8f9ff2320aa254db98960c80002ab5f9988cc933 Mon Sep 17 00:00:00 2001 From: TheFactoriousDROID Date: Sat, 24 Oct 2026 22:16:26 -0700 Subject: [PATCH] chore(core): remove skills that shadow Droid built-ins Delete core's simplify, init, and session-navigation, their skills/ symlinks, and their README lines. Droid ships newer built-in skills under the same names, and the plugin copies hide them. --- README.md | 5 - plugins/core/skills/init/SKILL.md | 23 ---- .../core/skills/session-navigation/SKILL.md | 122 ------------------ plugins/core/skills/simplify/SKILL.md | 53 -------- skills/init | 1 - skills/session-navigation | 1 - skills/simplify | 1 - 7 files changed, 206 deletions(-) delete mode 100644 plugins/core/skills/init/SKILL.md delete mode 100644 plugins/core/skills/session-navigation/SKILL.md delete mode 100644 plugins/core/skills/simplify/SKILL.md delete mode 120000 skills/init delete mode 120000 skills/session-navigation delete mode 120000 skills/simplify diff --git a/README.md b/README.md index 62f7f3f..9793470 100644 --- a/README.md +++ b/README.md @@ -28,10 +28,6 @@ Or browse available plugins via the UI: Core skills for essential functionalities and integrations. Pre-installed by the Droid CLI. -**Skills:** - -- `simplify` - Parallel code review across reuse, quality, and efficiency axes - **Output styles:** - `Explanatory` - Explains implementation choices and codebase patterns while completing the task @@ -90,7 +86,6 @@ Skills for continuous learning and improvement. **Skills:** -- `session-navigation` - Search and navigate past Droid sessions - `human-writing` - Remove AI writing patterns, make text sound human - `skill-creation` - Create and improve Droid skills - `visual-design` - Image generation (nanobanana CLI) and presentations (Slidev) diff --git a/plugins/core/skills/init/SKILL.md b/plugins/core/skills/init/SKILL.md deleted file mode 100644 index d291cea..0000000 --- a/plugins/core/skills/init/SKILL.md +++ /dev/null @@ -1,23 +0,0 @@ ---- -name: init -version: 1.0.0 -description: Initialize a new repository with AGENTS.md -disable-model-invocation: true ---- - -Please analyze this codebase and create a AGENTS.md file, which will be given to future instances of Droid to operate in this repository. - -What to add: - -1. Commands that will be commonly used, such as how to build, lint, and run tests. Include the necessary commands to develop in this codebase, such as how to run a single test. -2. High-level code architecture and structure so that future instances can be productive more quickly. Focus on the "big picture" architecture that requires reading multiple files to understand. - -Usage notes: - -- After analyzing the codebase, if no AGENTS.md exists, create it directly. If an AGENTS.md already exists, show the proposed new contents and ask for confirmation before modifying the file. -- When you make the initial AGENTS.md, do not repeat yourself and do not include obvious instructions like "Provide helpful error messages to users", "Write unit tests for all new utilities", "Never include sensitive information (API keys, tokens) in code or commits". -- Avoid listing every component or file structure that can be easily discovered. -- Don't include generic development practices. -- If there are Cursor rules (in .cursor/rules/ or .cursorrules), Copilot rules (in .github/copilot-instructions.md), or CLAUDE.md files, make sure to include the important parts. -- If there is a README.md, make sure to include the important parts. -- Do not make up information such as "Common Development Tasks", "Tips for Development", "Support and Documentation" unless this is expressly included in other files that you read. diff --git a/plugins/core/skills/session-navigation/SKILL.md b/plugins/core/skills/session-navigation/SKILL.md deleted file mode 100644 index c2c2960..0000000 --- a/plugins/core/skills/session-navigation/SKILL.md +++ /dev/null @@ -1,122 +0,0 @@ ---- -name: session-navigation -version: 1.1.0 -description: | - Navigate, search, and manage Droid sessions. Use when the user wants to: - - List recent sessions - - Search session history for specific topics or patterns - - Resume a previous session - - Get details about what was accomplished in a session - - Find sessions by project, date, or content ---- - -# Session navigation - -Find your way around past Droid sessions. Maybe you want to pick up where you left off, find that thing you did last week, or just see what's been happening in a project. - -## Where sessions live - -Sessions are in `~/.factory/sessions/`, organized by project folder. Each project gets its own directory with the path encoded (slashes become dashes): - -``` -~/.factory/sessions/ -├── -Users-enoreyes-code-work-myapp/ -│ ├── .jsonl -│ └── .settings.json -├── -Users-enoreyes-code-projects-api/ -│ ├── .jsonl -│ └── .settings.json -└── ... -``` - -Two files per session: - -**The conversation** (`.jsonl`): Each line is a JSON object. First line has metadata (session id, title, working directory). Rest is the back-and-forth: user messages, assistant responses, tool calls. - -**The settings** (`.settings.json`): Stats about the session. Which model, how long it ran, token counts, autonomy mode. - -## Finding sessions - -### List project folders - -```bash -# See all project folders with sessions -ls ~/.factory/sessions/ - -# Find folders for a specific project (partial match) -ls ~/.factory/sessions/ | grep "myapp" -``` - -### Recent sessions in a project - -```bash -# List sessions by date for a project -ls -lt ~/.factory/sessions/-Users-enoreyes-code-work-myapp/ - -# Get titles of recent sessions -for f in $(ls -t ~/.factory/sessions/-Users-enoreyes-code-work-myapp/*.jsonl | head -10); do - echo "=== $f ===" - head -1 "$f" | jq -r '.title // "Untitled"' -done -``` - -### Search by content - -```bash -# Search across ALL sessions -rg "authentication" ~/.factory/sessions/ - -# Search within a specific project -rg "bug fix" ~/.factory/sessions/-Users-enoreyes-code-work-myapp/ - -# See matches in context -rg -C 2 "login" ~/.factory/sessions/-Users-enoreyes-code-projects-api/ -``` - -### Find which project has sessions about something - -```bash -# Which projects have sessions mentioning "redis"? -rg -l "redis" ~/.factory/sessions/ | cut -d'/' -f1-5 | sort -u -``` - -## Reading a session - -Once you've found a session file: - -```bash -# The metadata (title, working directory) -head -1 ~/.factory/sessions/-Users-enoreyes-code-work-myapp/.jsonl | jq . - -# Session stats (model, tokens, duration) -cat ~/.factory/sessions/-Users-enoreyes-code-work-myapp/.settings.json | jq . - -# How long was this conversation? -wc -l ~/.factory/sessions/-Users-enoreyes-code-work-myapp/.jsonl -``` - -User messages have `"role": "user"`, assistant responses have `"role": "assistant"`. Tool calls show what commands ran and what files got touched. - -## Common situations - -**"What did I work on in this project?"** -List that project's session folder, check dates, read through the conversation files. - -**"Find that session where we fixed the login bug"** -Search for "login" or "auth" across sessions. Once you find it, read the conversation. - -**"Resume what I was doing"** -Find the session, read through what happened, summarize the key decisions before continuing. - -**"How much have I been using Droid?"** -The settings files have token counts and active time. Sum across sessions if needed. - -## Tips - -Use `rg` (ripgrep) instead of grep. It's faster and handles nested folders better. - -Project paths have slashes replaced with dashes. `/Users/me/code/app` becomes `-Users-me-code-app`. - -The session title isn't always helpful. Sometimes you need to read the conversation to know what it was about. - -Sessions can contain sensitive stuff. Be careful about what you surface. diff --git a/plugins/core/skills/simplify/SKILL.md b/plugins/core/skills/simplify/SKILL.md deleted file mode 100644 index aa8ea43..0000000 --- a/plugins/core/skills/simplify/SKILL.md +++ /dev/null @@ -1,53 +0,0 @@ ---- -name: simplify -description: Review changed code for reuse, quality, and efficiency, then fix any issues found. ---- - -# Simplify: Code Review and Cleanup - -Review all changed files for reuse, quality, and efficiency. Fix any issues found. - -## Phase 1: Identify Changes - -Run `git diff` (or `git diff HEAD` if there are staged changes) to see what changed. If there are no git changes, review the most recently modified files that the user mentioned or that you edited earlier in this conversation. - -## Phase 2: Launch Three Review Agents in Parallel - -Use the Task tool to launch all three agents concurrently in a single message. Pass each agent the full diff so it has the complete context. - -### Agent 1: Code Reuse Review - -For each change: - -1. **Search for existing utilities and helpers** that could replace newly written code. Look for similar patterns elsewhere in the codebase — common locations are utility directories, shared modules, and files adjacent to the changed ones. -2. **Flag any new function that duplicates existing functionality.** Suggest the existing function to use instead. -3. **Flag any inline logic that could use an existing utility** — hand-rolled string manipulation, manual path handling, custom environment checks, ad-hoc type guards, and similar patterns are common candidates. - -### Agent 2: Code Quality Review - -Review the same changes for hacky patterns: - -1. **Redundant state**: state that duplicates existing state, cached values that could be derived, observers/effects that could be direct calls -2. **Parameter sprawl**: adding new parameters to a function instead of generalizing or restructuring existing ones -3. **Copy-paste with slight variation**: near-duplicate code blocks that should be unified with a shared abstraction -4. **Leaky abstractions**: exposing internal details that should be encapsulated, or breaking existing abstraction boundaries -5. **Stringly-typed code**: using raw strings where constants, enums (string unions), or branded types already exist in the codebase -6. **Unnecessary JSX nesting**: wrapper Boxes/elements that add no layout value — check if inner component props (flexShrink, alignItems, etc.) already provide the needed behavior - -### Agent 3: Efficiency Review - -Review the same changes for efficiency: - -1. **Unnecessary work**: redundant computations, repeated file reads, duplicate network/API calls, N+1 patterns -2. **Missed concurrency**: independent operations run sequentially when they could run in parallel -3. **Hot-path bloat**: new blocking work added to startup or per-request/per-render hot paths -4. **Recurring no-op updates**: state/store updates inside polling loops, intervals, or event handlers that fire unconditionally — add a change-detection guard so downstream consumers aren't notified when nothing changed. Also: if a wrapper function takes an updater/reducer callback, verify it honors same-reference returns (or whatever the "no change" signal is) — otherwise callers' early-return no-ops are silently defeated -5. **Unnecessary existence checks**: pre-checking file/resource existence before operating (TOCTOU anti-pattern) — operate directly and handle the error -6. **Memory**: unbounded data structures, missing cleanup, event listener leaks -7. **Overly broad operations**: reading entire files when only a portion is needed, loading all items when filtering for one - -## Phase 3: Fix Issues - -Wait for all three agents to complete. Aggregate their findings and fix each issue directly. If a finding is a false positive or not worth addressing, note it and move on — do not argue with the finding, just skip it. - -When done, briefly summarize what was fixed (or confirm the code was already clean). diff --git a/skills/init b/skills/init deleted file mode 120000 index 0228cdc..0000000 --- a/skills/init +++ /dev/null @@ -1 +0,0 @@ -../plugins/core/skills/init \ No newline at end of file diff --git a/skills/session-navigation b/skills/session-navigation deleted file mode 120000 index 814b9b8..0000000 --- a/skills/session-navigation +++ /dev/null @@ -1 +0,0 @@ -../plugins/core/skills/session-navigation \ No newline at end of file diff --git a/skills/simplify b/skills/simplify deleted file mode 120000 index 6e6a3a0..0000000 --- a/skills/simplify +++ /dev/null @@ -1 +0,0 @@ -../plugins/core/skills/simplify \ No newline at end of file