diff --git a/practice-tdd/count.js b/practice-tdd/count.js index 5518c5712..e439447b2 100644 --- a/practice-tdd/count.js +++ b/practice-tdd/count.js @@ -1,3 +1,6 @@ export function countChar(stringOfCharacters, findCharacter) { - return 5 + if (findCharacter === "") { + return 0; + } + return stringOfCharacters.split(findCharacter).length - 1; } diff --git a/practice-tdd/count.test.js b/practice-tdd/count.test.js index cb3aaae59..3eb8035df 100644 --- a/practice-tdd/count.test.js +++ b/practice-tdd/count.test.js @@ -22,3 +22,47 @@ test("should count multiple occurrences of a character", () => { // And a character `char` that does not exist within `str`. // When the function is called with these inputs, // Then it should return 0, indicating that no occurrences of `char` were found. + +test("should return 0 for no occurrences of a specific character in the string ", () => { + const str = "aaaaa"; + const char = "b"; + const count = countChar(str, char); + expect(count).toEqual(0); +}); + +test("should return 0 if case of a specific character is not the same as in the string", () => { + const str = "AAAAA"; + const char = "a"; + const count = countChar(str, char); + expect(count).toEqual(0); +}); + +test("should return 0 if the string contains empty char and vice versa", () => { + let str = "AAAAA"; + let char = ""; + let count = countChar(str, char); + expect(count).toEqual(0); + str = ""; + char = "c"; + count = countChar(str, char); + expect(count).toEqual(0); +}); + +test("should count multiple occurrences of a non-english character", () => { + const str = "AAA%&&&0"; + const char = "%"; + const count = countChar(str, char); + expect(count).toEqual(1); +}); + +test("should count occurrences multiple characters in a string sequentially", () => { + let str = "AbCdEfGh"; + let char = "Ab"; + let count = countChar(str, char); + expect(count).toEqual(1); + + str = "AbCdEfGh"; + char = "AC"; + count = countChar(str, char); + expect(count).toEqual(0); +}); diff --git a/practice-tdd/get-ordinal-number.js b/practice-tdd/get-ordinal-number.js index 5c6291f5e..f3404aa1c 100644 --- a/practice-tdd/get-ordinal-number.js +++ b/practice-tdd/get-ordinal-number.js @@ -1,3 +1,14 @@ export function getOrdinalNumber(num) { - return "1st"; + const numStr = num.toString(); + const last2ndDigit = numStr.slice(-2, -1); + const last1stDigit = numStr.slice(-1); + + if (last1stDigit == "1" && last2ndDigit != "1") { + return `${numStr}st`; + } else if (last1stDigit == "2" && last2ndDigit != "1") { + return `${numStr}nd`; + } else if (last1stDigit == "3" && last2ndDigit != "1") { + return `${numStr}rd`; + } + return `${numStr}th`; } diff --git a/practice-tdd/get-ordinal-number.test.js b/practice-tdd/get-ordinal-number.test.js index e23174a18..e67a97119 100644 --- a/practice-tdd/get-ordinal-number.test.js +++ b/practice-tdd/get-ordinal-number.test.js @@ -18,3 +18,24 @@ test("should append 'st' for numbers ending with 1, except those ending with 11" expect(getOrdinalNumber(21)).toEqual("21st"); expect(getOrdinalNumber(131)).toEqual("131st"); }); + +test("should append 'nd' for numbers ending with 2, except those ending with 12", () => { + expect(getOrdinalNumber(2)).toEqual("2nd"); + expect(getOrdinalNumber(22)).toEqual("22nd"); + expect(getOrdinalNumber(132)).toEqual("132nd"); +}); + +test("should append 'rd' for numbers ending with 3, except those ending with 13", () => { + expect(getOrdinalNumber(3)).toEqual("3rd"); + expect(getOrdinalNumber(33)).toEqual("33rd"); + expect(getOrdinalNumber(143)).toEqual("143rd"); +}); + +test("should append 'th' for numbers ending with 0, range 4-9 or range 11-13", () => { + expect(getOrdinalNumber(111)).toEqual("111th"); + expect(getOrdinalNumber(120)).toEqual("120th"); + expect(getOrdinalNumber(134)).toEqual("134th"); + expect(getOrdinalNumber(234547)).toEqual("234547th"); + expect(getOrdinalNumber(123900)).toEqual("123900th"); + expect(getOrdinalNumber(90485)).toEqual("90485th"); +}); diff --git a/practice-tdd/repeat-str.js b/practice-tdd/repeat-str.js index af273f3b0..8e56763a9 100644 --- a/practice-tdd/repeat-str.js +++ b/practice-tdd/repeat-str.js @@ -1,5 +1,14 @@ -export function repeatStr() { +export function repeatStr(word, n) { // Your implementation of this function must *not* call String.prototype.repeat (https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/repeat). // The goal is to re-implement that function, not to use it. - return "hellohellohello"; + if (n < 0) { + throw new Error("Error"); + } else if (n === 0) { + return ""; + } + let nWords = ""; + for (let i = 0; i < n; i++) { + nWords = nWords + word; + } + return nWords; } diff --git a/practice-tdd/repeat-str.test.js b/practice-tdd/repeat-str.test.js index 8a7036102..3347b54f8 100644 --- a/practice-tdd/repeat-str.test.js +++ b/practice-tdd/repeat-str.test.js @@ -21,12 +21,34 @@ test("should repeat the string count times", () => { // When the repeatStr function is called with these inputs, // Then it should return the original `str` without repetition. +test("should repeat the string one time", () => { + const str = "hello"; + const count = 1; + const repeatedStr = repeatStr(str, count); + expect(repeatedStr).toEqual("hello"); +}); + // Case: Handle count of 0: // Given a target string `str` and a `count` equal to 0, // When the repeatStr function is called with these inputs, // Then it should return an empty string. +test("should return empty string if count is zero", () => { + const str = "hello"; + const count = 0; + const repeatedStr = repeatStr(str, count); + expect(repeatedStr).toEqual(""); +}); + // Case: Handle negative count: // Given a target string `str` and a negative integer `count`, // When the repeatStr function is called with these inputs, // Then it should throw an error, as negative counts are not valid. + +test("should throw an error when count is negative integer", () => { + const str = "hello"; + const count = -5; + expect(() => { + repeatStr(str, count); + }).toThrow("Error"); +});