From b7d00c04ac82d6fd3096ba3bb99df8198a301044 Mon Sep 17 00:00:00 2001 From: not-matthias Date: Thu, 29 Oct 2026 19:38:20 +0100 Subject: [PATCH] fix(exec-harness): add --always-sparkplug to the node wrapper flags codspeed-node requires --always-sparkplug in analysis mode: it compiles the benchmark eagerly with Sparkplug so the measured code does not tier up during the run. The wrapper mirrors getV8Flags(), so without it the integration sees a missing flag on the normal codspeed exec path. That surfaced with the integration-side restart: a benchmark process whose execArgv lacks any required flag replaces itself with the missing ones. Keeping the mirror complete means the restart only fires for launchers that really bypass the wrapper, such as Bazel's rules_js. Refs COD-4038 --- crates/exec-harness/src/runtime_env/node/node.sh | 1 + crates/exec-harness/src/runtime_env/node/tests.rs | 1 + 2 files changed, 2 insertions(+) diff --git a/crates/exec-harness/src/runtime_env/node/node.sh b/crates/exec-harness/src/runtime_env/node/node.sh index 1883e81dd..1ea947526 100644 --- a/crates/exec-harness/src/runtime_env/node/node.sh +++ b/crates/exec-harness/src/runtime_env/node/node.sh @@ -50,6 +50,7 @@ add_analysis_flags() { --hash-seed=1 --random-seed=1 --no-opt + --always-sparkplug --predictable --predictable-gc-schedule --expose-gc diff --git a/crates/exec-harness/src/runtime_env/node/tests.rs b/crates/exec-harness/src/runtime_env/node/tests.rs index 3657cc4ca..e0471b2f0 100644 --- a/crates/exec-harness/src/runtime_env/node/tests.rs +++ b/crates/exec-harness/src/runtime_env/node/tests.rs @@ -44,6 +44,7 @@ fn expected_flags(mode: &str, major: u32, v8_log: Option<&str>) -> Vec { "--hash-seed=1", "--random-seed=1", "--no-opt", + "--always-sparkplug", "--predictable", "--predictable-gc-schedule", "--expose-gc",